Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Run tests like in contributing guide #2149

Closed
wants to merge 1 commit into from
Closed

[Docs] Run tests like in contributing guide #2149

wants to merge 1 commit into from

Conversation

nchammas
Copy link
Contributor

The Contributing to Spark guide recommends running tests by calling ./dev/run-tests. The README should, too.

./sbt/sbt test does not cover Python tests or style tests.

The Contributing to Spark guide [recommends](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-AutomatedTesting) running tests by calling `run-tests`. The README should, too.

`./sbt/sbt test` does not cover Python tests or style tests.
@SparkQA
Copy link

SparkQA commented Aug 26, 2014

QA tests have started for PR 2149 at commit 2b3b132.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 26, 2014

QA tests have finished for PR 2149 at commit 2b3b132.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@nchammas
Copy link
Contributor Author

Err, looks like some Hive test failed. Don't understand why.

@nchammas
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 26, 2014

QA tests have started for PR 2149 at commit 2b3b132.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 26, 2014

QA tests have finished for PR 2149 at commit 2b3b132.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@nchammas
Copy link
Contributor Author

OK, this time it's a PySpark failure. I'm not sure what's going on.

@rxin Could you take a look? This should be a very quick review.

@JoshRosen
Copy link
Contributor

I think this error could be some sort of flakiness / interference from other Jenkins workers on the same box; maybe we ran out of ephemeral ports or something.

Jenkins, retest this please.

@rxin
Copy link
Contributor

rxin commented Aug 27, 2014

Jenkins, retest this please.

@rxin
Copy link
Contributor

rxin commented Aug 27, 2014

Actually I'm going to merge it since the change has no effect on the tests.

@asfgit asfgit closed this in 73b3089 Aug 27, 2014
asfgit pushed a commit that referenced this pull request Aug 27, 2014
The Contributing to Spark guide [recommends](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-AutomatedTesting) running tests by calling `./dev/run-tests`. The README should, too.

`./sbt/sbt test` does not cover Python tests or style tests.

Author: nchammas <nicholas.chammas@gmail.com>

Closes #2149 from nchammas/patch-2 and squashes the following commits:

2b3b132 [nchammas] [Docs] Run tests like in contributing guide

(cherry picked from commit 73b3089)
Signed-off-by: Reynold Xin <rxin@apache.org>
@nchammas nchammas deleted the patch-2 branch August 28, 2014 20:57
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
The Contributing to Spark guide [recommends](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-AutomatedTesting) running tests by calling `./dev/run-tests`. The README should, too.

`./sbt/sbt test` does not cover Python tests or style tests.

Author: nchammas <nicholas.chammas@gmail.com>

Closes apache#2149 from nchammas/patch-2 and squashes the following commits:

2b3b132 [nchammas] [Docs] Run tests like in contributing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants