Revert [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetastoreOrc by default #20536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by default" This reverts commit aa1764b.
|
Given how late it is in the cycle, let’s revert this to avoid delaying the release, but add to release notes on how to turn it on manually |
|
Thank you for pining me. +1 for the decision. |
dongjoon-hyun
approved these changes
Feb 7, 2018
|
Test build #87175 has finished for PR 20536 at commit
|
|
thanks, merging to master/2.3! |
asfgit
pushed a commit
that referenced
this pull request
Feb 8, 2018
…by default ## What changes were proposed in this pull request? This is to revert the changes made in #19499 , because this causes a regression. We should not ignore the table-specific compression conf when the Hive serde tables are converted to the data source tables. ## How was this patch tested? The existing tests. Author: gatorsmile <gatorsmile@gmail.com> Closes #20536 from gatorsmile/revert22279. (cherry picked from commit 3473fda) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Feb 12, 2018
…by default ## What changes were proposed in this pull request? This is to revert the changes made in apache#19499 , because this causes a regression. We should not ignore the table-specific compression conf when the Hive serde tables are converted to the data source tables. ## How was this patch tested? The existing tests. Author: gatorsmile <gatorsmile@gmail.com> Closes apache#20536 from gatorsmile/revert22279.
asfgit
pushed a commit
that referenced
this pull request
May 10, 2018
## What changes were proposed in this pull request? We reverted `spark.sql.hive.convertMetastoreOrc` at #20536 because we should not ignore the table-specific compression conf. Now, it's resolved via [SPARK-23355](8aa1d7b). ## How was this patch tested? Pass the Jenkins. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #21186 from dongjoon-hyun/SPARK-24112.
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
We reverted `spark.sql.hive.convertMetastoreOrc` at apache#20536 because we should not ignore the table-specific compression conf. Now, it's resolved via [SPARK-23355](apache@8aa1d7b). Pass the Jenkins. Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#21186 from dongjoon-hyun/SPARK-24112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is to revert the changes made in #19499 , because this causes a regression. We should not ignore the table-specific compression conf when the Hive serde tables are converted to the data source tables.
How was this patch tested?
The existing tests.