Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-23310][CORE][FOLLOWUP] Fix Java style check issues. #20514

Closed
wants to merge 1 commit into from
Closed

[SPARK-23310][CORE][FOLLOWUP] Fix Java style check issues. #20514

wants to merge 1 commit into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Feb 6, 2018

What changes were proposed in this pull request?

This is a follow-up of #20492 which broke lint-java checks.
This pr fixes the lint-java issues.

[ERROR] src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:[79] (sizes) LineLength: Line is longer than 100 characters (found 114).

How was this patch tested?

Checked manually in my local environment.

@ueshin
Copy link
Member Author

ueshin commented Feb 6, 2018

cc @sitalkedia @sameeragarwal

sameeragarwal
sameeragarwal approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@sameeragarwal sameeragarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ueshin, LGTM!

@sitalkedia
Copy link

LGTM, thanks for fixing this.

@SparkQA
Copy link

SparkQA commented Feb 6, 2018

Test build #87089 has finished for PR 20514 at commit 405418a.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@kiszk
Copy link
Member

kiszk commented Feb 6, 2018

LGTM

@SparkQA
Copy link

SparkQA commented Feb 6, 2018

Test build #87096 has finished for PR 20514 at commit 405418a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member Author

ueshin commented Feb 6, 2018

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Feb 6, 2018

Test build #87105 has finished for PR 20514 at commit 405418a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Feb 6, 2018

Test build #87110 has finished for PR 20514 at commit 405418a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Feb 6, 2018

Merging to master / 2.3.

asfgit pushed a commit that referenced this pull request Feb 6, 2018
@ueshin
[SPARK-23310][CORE][FOLLOWUP] Fix Java style check issues.
7782fd0 
## What changes were proposed in this pull request?

This is a follow-up of #20492 which broke lint-java checks.
This pr fixes the lint-java issues.

```
[ERROR] src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:[79] (sizes) LineLength: Line is longer than 100 characters (found 114).
```

## How was this patch tested?

Checked manually in my local environment.

Author: Takuya UESHIN <ueshin@databricks.com>

Closes #20514 from ueshin/issues/SPARK-23310/fup1.

(cherry picked from commit 7db9979)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@asfgit asfgit closed this in 7db9979 Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameeragarwal sameeragarwal sameeragarwal approved these changes

@jiangxb1987 jiangxb1987 jiangxb1987 approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ueshin @sitalkedia @SparkQA @HyukjinKwon @kiszk @vanzin @sameeragarwal @jiangxb1987