[SPARK-23312][SQL] add a config to turn off vectorized cache reader #20483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| buildConf("spark.sql.inMemoryColumnarStorage.enableVectorizedReader") | ||
| .doc("Enables vectorized reader for columnar caching.") | ||
| .booleanConf | ||
| .createWithDefault(true) |
There was a problem hiding this comment.
To unblock 2.3, I think we need to disable this with false.
Sorry, I'm taking this back since it's too radical in general.
There was a problem hiding this comment.
the parquet/orc vectorized reader conf is also public.
felixcheung
approved these changes
Feb 2, 2018
|
Test build #86966 has finished for PR 20483 at commit
|
|
Test build #86967 has finished for PR 20483 at commit
|
|
retest this please. |
|
Test build #86983 has finished for PR 20483 at commit
|
|
thanks, merging to master/2.3! |
asfgit
pushed a commit
that referenced
this pull request
Feb 2, 2018
## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-23309 reported a performance regression about cached table in Spark 2.3. While the investigating is still going on, this PR adds a conf to turn off the vectorized cache reader, to unblock the 2.3 release. ## How was this patch tested? a new test Author: Wenchen Fan <wenchen@databricks.com> Closes #20483 from cloud-fan/cache. (cherry picked from commit b9503fc) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
Thank you for adding this. I will look at the performance regression. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Feb 6, 2018
…e reader ## What changes were proposed in this pull request? apache#20483 tried to provide a way to turn off the new columnar cache reader, to restore the behavior in 2.2. However even we turn off that config, the behavior is still different than 2.2. If the output data are rows, we still enable whole stage codegen for the scan node, which is different with 2.2, we should also fix it. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#20513 from cloud-fan/cache.
asfgit
pushed a commit
that referenced
this pull request
Feb 6, 2018
…e reader ## What changes were proposed in this pull request? #20483 tried to provide a way to turn off the new columnar cache reader, to restore the behavior in 2.2. However even we turn off that config, the behavior is still different than 2.2. If the output data are rows, we still enable whole stage codegen for the scan node, which is different with 2.2, we should also fix it. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes #20513 from cloud-fan/cache. (cherry picked from commit ac7454c) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Feb 12, 2018
…e reader ## What changes were proposed in this pull request? apache#20483 tried to provide a way to turn off the new columnar cache reader, to restore the behavior in 2.2. However even we turn off that config, the behavior is still different than 2.2. If the output data are rows, we still enable whole stage codegen for the scan node, which is different with 2.2, we should also fix it. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#20513 from cloud-fan/cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-23309 reported a performance regression about cached table in Spark 2.3. While the investigating is still going on, this PR adds a conf to turn off the vectorized cache reader, to unblock the 2.3 release.
How was this patch tested?
a new test