[SPARK-23197][DStreams] Increased timeouts to resolve flakiness #20371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sameeragarwal this PR should fix this flakiness. |
| @@ -105,13 +105,13 @@ class ReceiverSuite extends TestSuiteBase with TimeLimits with Serializable { | |||
| assert(executor.errors.head.eq(exception)) | |||
|
|
|||
| // Verify restarting actually stops and starts the receiver | |||
| receiver.restart("restarting", null, 100) | |||
| eventually(timeout(50 millis), interval(10 millis)) { | |||
| receiver.restart("restarting", null, 600) | |||
There was a problem hiding this comment.
If these timeout bumps fix the flakiness, we should also consider enabling the "block generator throttling" test below (it was disabled via b69c4f9)
There was a problem hiding this comment.
yeah. lets fix one at a time.
|
LGTM, pending jenkins. Thanks! |
|
Test build #4076 has finished for PR 20371 at commit
|
|
Test build #4074 has finished for PR 20371 at commit
|
|
Test build #4075 has finished for PR 20371 at commit
|
|
Test build #4072 has finished for PR 20371 at commit
|
|
Test build #4073 has finished for PR 20371 at commit
|
|
Test build #86550 has finished for PR 20371 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 24, 2018
## What changes were proposed in this pull request? Increased timeout from 50 ms to 300 ms (50 ms was really too low). ## How was this patch tested? Multiple rounds of tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes #20371 from tdas/SPARK-23197. (cherry picked from commit 15adcc8) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increased timeout from 50 ms to 300 ms (50 ms was really too low).
How was this patch tested?
Multiple rounds of tests.