[SPARK-21727][R] Allow multi-element atomic vector as column type in SparkR DataFrame #20352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, ok to test |
|
@neilalex Can you add the code snippet in the PR description as a new test case ? That way we will ensure this behavior is tested going forward |
|
sure |
|
Test build #86494 has finished for PR 20352 at commit
|
|
@shivaram alright, should be good with the tests now -- let me know how it seems |
|
Test build #86500 has finished for PR 20352 at commit
|
|
Thanks @neilalex - Change LGTM. Lets also see if @felixcheung has any comments. |
|
That looks good. Thanks! We work together on this fix so I’m pretty confident about this change.
On a side note assuming we push this to 2.3 should we add the behavior change to the R programming guide migration guide section?
|
felixcheung
approved these changes
Jan 23, 2018
asfgit
pushed a commit
that referenced
this pull request
Jan 24, 2018
…SparkR DataFrame ## What changes were proposed in this pull request? A fix to https://issues.apache.org/jira/browse/SPARK-21727, "Operating on an ArrayType in a SparkR DataFrame throws error" ## How was this patch tested? - Ran tests at R\pkg\tests\run-all.R (see below attached results) - Tested the following lines in SparkR, which now seem to execute without error: ``` indices <- 1:4 myDf <- data.frame(indices) myDf$data <- list(rep(0, 20)) mySparkDf <- as.DataFrame(myDf) collect(mySparkDf) ``` [2018-01-22 SPARK-21727 Test Results.txt](https://github.com/apache/spark/files/1653535/2018-01-22.SPARK-21727.Test.Results.txt) felixcheung yanboliang sun-rui shivaram _The contribution is my original work and I license the work to the project under the project’s open source license_ Author: neilalex <neil@neilalex.com> Closes #20352 from neilalex/neilalex-sparkr-arraytype. (cherry picked from commit f54b65c) Signed-off-by: Felix Cheung <felixcheung@apache.org>
|
merged to master/2.3. we could revisit migration guide if necessary. |
|
@felixcheung @yanboliang @shivaram thank you for your guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A fix to https://issues.apache.org/jira/browse/SPARK-21727, "Operating on an ArrayType in a SparkR DataFrame throws error"
How was this patch tested?
2018-01-22 SPARK-21727 Test Results.txt
@felixcheung @yanboliang @sun-rui @shivaram
The contribution is my original work and I license the work to the project under the project’s open source license