[SPARK-23091][ML] Incorrect unit test for approxQuantile #20324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchenphy
approved these changes
Jan 19, 2018
|
Test build #86364 has finished for PR 20324 at commit
|
|
Retest this please. |
|
Test build #86368 has finished for PR 20324 at commit
|
viirya
reviewed
Jan 19, 2018
| assert(math.abs(s2 - q2 * n) < error_single) | ||
| assert(math.abs(d1 - 2 * q1 * n) < error_double) | ||
| assert(math.abs(d2 - 2 * q2 * n) < error_double) | ||
| assert(math.abs(single1 - q1 * n) < errorSingle) |
There was a problem hiding this comment.
Seems the intervals are inclusive, so this might be <= instead of <?
|
Test build #86390 has finished for PR 20324 at commit
|
|
LGTM. Thanks! 👍 |
|
LGTM |
|
Thanks! Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2018
## What changes were proposed in this pull request? Narrow bound on approx quantile test to epsilon from 2*epsilon to match paper ## How was this patch tested? Existing tests. Author: Sean Owen <sowen@cloudera.com> Closes #20324 from srowen/SPARK-23091. (cherry picked from commit 396cdfb) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Narrow bound on approx quantile test to epsilon from 2*epsilon to match paper
How was this patch tested?
Existing tests.