[SPARK-23143][SS][PYTHON] Added python API for setting continuous trigger #20309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zsxwing @jose-torres please take a look. |
|
Test build #86319 has finished for PR 20309 at commit
|
|
Test build #86323 has finished for PR 20309 at commit
|
|
Test build #86329 has finished for PR 20309 at commit
|
|
jenkins retest this please |
|
Test build #86334 has finished for PR 20309 at commit
|
HyukjinKwon
reviewed
Jan 18, 2018
| @@ -1518,6 +1518,12 @@ def test_stream_trigger(self): | |||
| except ValueError: | |||
| pass | |||
|
|
|||
| # Should not take multiple args | |||
| try: | |||
There was a problem hiding this comment.
@tdas, could we maybe test this by assertRaises if it checks raising an exception?
jose-torres
reviewed
Jan 18, 2018
| @@ -802,23 +802,38 @@ def trigger(self, processingTime=None, once=None): | |||
| >>> writer = sdf.writeStream.trigger(processingTime='5 seconds') | |||
| >>> # trigger the query for just once batch of data | |||
| >>> writer = sdf.writeStream.trigger(once=True) | |||
| >>> # trigger the query for execution every 5 seconds | |||
There was a problem hiding this comment.
nit: not quite the right comment
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2018
…gger ## What changes were proposed in this pull request? Self-explanatory. ## How was this patch tested? New python tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes #20309 from tdas/SPARK-23143. (cherry picked from commit 2d41f04) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
|
Merged it in the hope of making it to the RC2. Will address comments in a different PR. Thanks @jose-torres and @HyukjinKwon for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Self-explanatory.
How was this patch tested?
New python tests.