-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-23119][SS] Minor fixes to V2 streaming APIs #20286
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
|
||
package org.apache.spark.sql.sources.v2.streaming.reader; | ||
|
||
import org.apache.spark.annotation.InterfaceStability; | ||
import org.apache.spark.sql.sources.v2.reader.DataSourceV2Reader; | ||
import org.apache.spark.sql.execution.streaming.BaseStreamingSource; | ||
|
||
|
@@ -25,7 +26,11 @@ | |
/** | ||
* A mix-in interface for {@link DataSourceV2Reader}. Data source readers can implement this | ||
* interface to indicate they allow micro-batch streaming reads. | ||
* | ||
* Note: This class currently extends {@link BaseStreamingSource} to maintain compatibility with | ||
* DataSource V1 APIs. This will be extension will be removed once we get rid of V1 completely. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
*/ | ||
@InterfaceStability.Evolving | ||
public interface MicroBatchReader extends DataSourceV2Reader, BaseStreamingSource { | ||
/** | ||
* Set the desired offset range for read tasks created from this reader. Read tasks will | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,12 +17,20 @@ | |
|
||
package org.apache.spark.sql.sources.v2.streaming.reader; | ||
|
||
import org.apache.spark.annotation.InterfaceStability; | ||
|
||
/** | ||
* An abstract representation of progress through a [[MicroBatchReader]] or [[ContinuousReader]]. | ||
* During execution, Offsets provided by the data source implementation will be logged and used as | ||
* restart checkpoints. Sources should provide an Offset implementation which they can use to | ||
* reconstruct the stream position where the offset was taken. | ||
* An abstract representation of progress through a {@link MicroBatchReader} or | ||
* {@link ContinuousReader}. | ||
* During execution, offsets provided by the data source implementation will be logged and used as | ||
* restart checkpoints. Each source should provide an offset implementation which the source can use | ||
* to reconstruct a position in the stream up to which data has been seen/processed. | ||
* | ||
* Note: This class currently extends {@link org.apache.spark.sql.execution.streaming.Offset} to | ||
* maintain compatibility with DataSource V1 APIs. This will be extension will be removed once we | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
* get rid of V1 completely. | ||
*/ | ||
@InterfaceStability.Evolving | ||
public abstract class Offset extends org.apache.spark.sql.execution.streaming.Offset { | ||
/** | ||
* A JSON-serialized representation of an Offset that is | ||
|
@@ -37,7 +45,7 @@ public abstract class Offset extends org.apache.spark.sql.execution.streaming.Of | |
/** | ||
* Equality based on JSON string representation. We leverage the | ||
* JSON representation for normalization between the Offset's | ||
* in memory and on disk representations. | ||
* in deserialized and serialized representations. | ||
*/ | ||
@Override | ||
public boolean equals(Object obj) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This
will beextension