Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-22896 Improvement in String interpolation #20070

Closed
wants to merge 12 commits into from
Closed

SPARK-22896 Improvement in String interpolation #20070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9916fd1
SPARK-22896 Improvement in String interpolation
chetkhatri Dec 24, 2017
162ac27
SPARK-22896 Improvement in String interpolation - fixed typo
chetkhatri Dec 24, 2017
aa2de00
Merge branch 'master' of https://github.com/apache/spark into mllib-c…
chetkhatri Dec 24, 2017
74d41d7
graphx changed got merged to mllib example
chetkhatri Dec 26, 2017
8d729fa
All examples under spark scala - String interpolation has implemented
chetkhatri Dec 26, 2017
5507cad
All examples under spark scala - String interpolation has implemented…
chetkhatri Dec 26, 2017
79e6789
Spark scala code change for request addressed
chetkhatri Dec 28, 2017
70ce734
new line at the end of file added
chetkhatri Dec 29, 2017
0321faf
typo fixed
chetkhatri Dec 29, 2017
c33e90c
Review changes addressed
chetkhatri Dec 31, 2017
18d047f
Changes - II addressed
chetkhatri Jan 1, 2018
e891f53
Changes - III addressed
chetkhatri Jan 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/src/main/scala/org/apache/spark/examples/mllib/HypothesisTestingExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ object HypothesisTestingExample {
// against the label.
val featureTestResults: Array[ChiSqTestResult] = Statistics.chiSqTest(obs)
featureTestResults.zipWithIndex.foreach { case (k, v) =>
println(s"Column ${(v + 1).toString} :")
println(s"Column ${(v + 1)} :")
println(k)
} // summary of the test
// $example off$
Expand Down
5 changes: 4 additions & 1 deletion ...les/src/main/scala/org/apache/spark/examples/mllib/LatentDirichletAllocationExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ object LatentDirichletAllocationExample {
val topics = ldaModel.topicsMatrix
for (topic <- Range(0, 3)) {
print(s"Topic $topic :")
for (word <- Range(0, ldaModel.vocabSize)) { print(s" ${topics(word, topic)}") }
for (word <- Range(0, ldaModel.vocabSize))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we put the open brace on the preceding line with for, and don't triple indent. See any other for loop in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen sure done.

print(s" ${topics(word, topic)}")
}
println()
}

Expand Down