[SPARK-22778][Kubernetes] Added the missing service metadata for KubernetesClusterManager #19972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnetesClusterManager
|
LGTM. |
|
@vanzin @felixcheung @jiangxb1987 Can one of you help take a look and merge? This is fixing a blocker issue for Kubernetes mode. Thanks! |
|
Test build #84878 has finished for PR 19972 at commit
|
|
One of the tests failures looks legitimate... |
|
Test build #84888 has finished for PR 19972 at commit
|
|
LGTM
|
jiangxb1987
reviewed
Dec 14, 2017
| @@ -0,0 +1 @@ | |||
| org.apache.spark.scheduler.cluster.k8s.KubernetesClusterManager | |||
There was a problem hiding this comment.
nit: add an extra empty line below this
3 tasks
|
Test build #84920 has finished for PR 19972 at commit
|
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR added the missing service metadata for
KubernetesClusterManager. Without the metadata, the service loader couldn't loadKubernetesClusterManager, and caused the driver to fail to create aExternalClusterManager, as being reported in SPARK-22778. The PR also changed thek8s:prefix used tok8s://, which is what existing Spark on k8s users are familiar and used to.How was this patch tested?
Manual testing verified that the fix resolved the issue in SPARK-22778.
/cc @vanzin @felixcheung @jiangxb1987