[SPARK-22672][TEST][SQL] Move OrcTest to sql/core
#19863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #84381 has finished for PR 19863 at commit
|
gatorsmile
reviewed
Dec 2, 2017
| import org.apache.spark.sql.test.SQLTestUtils | ||
|
|
||
| private[sql] trait OrcTest extends SQLTestUtils with TestHiveSingleton { | ||
| abstract class OrcTest extends QueryTest with SQLTestUtils { |
There was a problem hiding this comment.
When we have not moved the test suites of ORC, why we need to move this out of Hive now?
There was a problem hiding this comment.
Unlike the previous ORC PRs, #19651 intentionally uses the existing old Hive tests suites. This PR is a preparation for moving test cases.
There was a problem hiding this comment.
Since this PR is tiny, we can do it when the other PRs are merged.
There was a problem hiding this comment.
As you see, we can do this without merging other ORC PRs, and this will reduce the scope of review for the other PRs.
|
@gatorsmile . Since the main PR is merged, I'll include this into the others. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To support ORC tests without Hive, we had better have
OrcTestinsql/coreinstead ofsql/hive.How was this patch tested?
This is a test suite only change. It should pass all existing tests.