Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-22159][SQL] Make config names consistently end with "enabled". #19384

Closed
wants to merge 3 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Sep 28, 2017

What changes were proposed in this pull request?

spark.sql.execution.arrow.enable and spark.sql.codegen.aggregate.map.twolevel.enable -> enabled

How was this patch tested?

N/A

spark.sql.execution.arrow.enable and spark.sql.codegen.aggregate.map.twolevel.enable -> enabled
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Sep 28, 2017

Test build #82286 has finished for PR 19384 at commit d41e347.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Update the PR title and description?

@rxin
Copy link
Contributor Author

rxin commented Sep 28, 2017

hm the 2nd commit is not meant for this one.

… in range shuffle exchange"

This reverts commit 8e51ae5.
@rxin
Copy link
Contributor Author

rxin commented Sep 28, 2017

I reverted the 2nd commit. Should be good for merge now.

@gatorsmile
Copy link
Member

Thanks! Merged to master

@asfgit asfgit closed this in d29d1e8 Sep 28, 2017
@SparkQA
Copy link

SparkQA commented Sep 29, 2017

Test build #82289 has finished for PR 19384 at commit 8e51ae5.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 29, 2017

Test build #82297 has finished for PR 19384 at commit 3d82277.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

wangyum pushed a commit to 1haodian/spark that referenced this pull request Oct 10, 2017
… "enabled".

## What changes were proposed in this pull request?

This is a follow-up of apache#19384.

In the previous pr, only definitions of the config names were modified, but we also need to modify the names in runtime or tests specified as string literal.

## How was this patch tested?

Existing tests but modified the config names.

Author: Takuya UESHIN <ueshin@databricks.com>

Closes apache#19462 from ueshin/issues/SPARK-22159/fup1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants