[SPARK-22142][BUILD][STREAMING] Move Flume support behind a profile #19365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
commented
Sep 27, 2017
| @@ -1478,7 +1478,7 @@ def search_kafka_assembly_jar(): | |||
| ("Failed to find Spark Streaming kafka assembly jar in %s. " % kafka_assembly_dir) + | |||
| "You need to build Spark with " | |||
| "'build/sbt assembly/package streaming-kafka-0-8-assembly/assembly' or " | |||
| "'build/mvn package' before running this test.") | |||
| "'build/mvn -Pkafka-0-8 package' before running this test.") | |||
There was a problem hiding this comment.
Not strictly related, but I noticed this when making a similar modification in the message below
|
Test build #82237 has finished for PR 19365 at commit
|
|
Merged to master |
|
A few test cases failed. Could we revert this first? |
|
Just revert it back. Please submit a new PR. Thanks! |
|
Hm, not sure why it passed Maven and the SBT PR builder. Yeah I'll have to look into it. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Oct 6, 2017
…take 2 ## What changes were proposed in this pull request? Move flume behind a profile, take 2. See apache#19365 for most of the back-story. This change should fix the problem by removing the examples module dependency and moving Flume examples to the module itself. It also adds deprecation messages, per a discussion on dev about deprecating for 2.3.0. ## How was this patch tested? Existing tests, which still enable flume integration. Author: Sean Owen <sowen@cloudera.com> Closes apache#19412 from srowen/SPARK-22142.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add 'flume' profile to enable Flume-related integration modules
How was this patch tested?
Existing tests; no functional change