[SPARK-22130][Core] UTF8String.trim() scans " " twice #19355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Sep 26, 2017
| } | ||
| // skip all of the space (0x20) in the right side | ||
| while (e >= 0 && getByte(e) == 0x20) e--; |
There was a problem hiding this comment.
Nit: while you're optimizing this, you can bring the declaration of e down here, as it won't be used unless there's a non-space char.
I think this condition can start with e > s too. At the end, s and e point to the first and last non-space char. When the loop starts, s points to a non-space char. So you can stop when e == s; this is the case of one non-space char.
Might be worth adding test cases for an empty string, and single-non-char string too.
srowen
approved these changes
Sep 26, 2017
|
Test build #82205 has finished for PR 19355 at commit
|
|
Test build #82209 has finished for PR 19355 at commit
|
|
Retest this please. |
|
Test build #82210 has finished for PR 19355 at commit
|
HyukjinKwon
approved these changes
Sep 27, 2017
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR allows us to scan a string including only white space (e.g.
" ") once while the current implementation scans twice (right to left, and then left to right).How was this patch tested?
Existing test suites