[SPARK-22103][FOLLOWUP] Rename addExtraCode to addInnerClass #19353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @viirya I addressed the post-merge comments you had in #19324 |
viirya
reviewed
Sep 26, 2017
| @@ -335,16 +335,15 @@ class CodegenContext { | |||
| * Emits any source code added with addExtraCode | |||
There was a problem hiding this comment.
nit: Emits extra classes added ...
There was a problem hiding this comment.
Emits extra inner classes added ...
|
LGTM |
1 similar comment
|
LGTM |
|
Test build #82197 has finished for PR 19353 at commit
|
|
jenkins retest this please |
|
Test build #82199 has finished for PR 19353 at commit
|
|
Thanks! Merged to master. |
|
Test build #82204 has finished for PR 19353 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address PR comments that appeared post-merge, to rename
addExtraCodetoaddInnerClass,and not count the size of the inner class to the size of the outer class.
How was this patch tested?
YOLO.