-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAPRK-20785][WEB-UI][SQL] Spark should provide jump links and add (count) in the SQL web ui. #19346
Conversation
@HyukjinKwon @jerryshao @ajbozarth |
ok to test. |
Please fix the title. |
Test build #82171 has finished for PR 19346 at commit
|
GLTM. @gatorsmile , would you please take a look at this PR, is it good for you? |
@gatorsmile Help to review the code. |
} | ||
{ | ||
if (listener.getCompletedExecutions.nonEmpty) { | ||
<li id="completed-summary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think completed-summary
is for ui test on jobs and stages pages. We may no need to use it here if no test for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the style for completed-summary
. Do we have defined style for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant id=completed-summary
looks like is basically used for ui test against jobs and stages pages. I can't find we actually defined a style for it. If you don't add a test for it in this execution page, we may not need to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not talking this kind of style. I meant any css style defined for id=completed-summary
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand what you mean. I will delete it. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply said, I think we can just write <li>
instead of <li id="completed-summary">
at this line.
LGTM |
Test build #82222 has finished for PR 19346 at commit
|
retest this please. |
Test build #82224 has finished for PR 19346 at commit
|
Test build #82225 has finished for PR 19346 at commit
|
retest this please. |
retest this please |
Test build #82234 has finished for PR 19346 at commit
|
OK, let me merge to master branch. |
What changes were proposed in this pull request?
propose:
it provide links that jump to Running Queries,Completed Queries and Failed Queries.
it add (count) about Running Queries,Completed Queries and Failed Queries.
This is a small optimization in in the SQL web ui.
fix before:
fix after:

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.