[MINOR][BUILD] Fix build warnings and Java lint errors #19051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
commented
Aug 25, 2017
| @@ -31,7 +32,7 @@ | |||
| * </p> | |||
| */ | |||
| @Private | |||
| public interface KVStoreIterator<T> extends Iterator<T>, AutoCloseable { | |||
| public interface KVStoreIterator<T> extends Iterator<T>, Closeable { | |||
There was a problem hiding this comment.
Weird one, but it warns on extending AutoCloseable without explicitly narrowing the exceptions that close() throws to not include InterruptedException.
| @@ -187,14 +187,13 @@ class CrossValidatorSuite | |||
| cv2.getEstimator match { | |||
| case ova2: OneVsRest => | |||
| assert(ova.uid === ova2.uid) | |||
| val classifier = ova2.getClassifier | |||
| classifier match { | |||
| ova2.getClassifier match { | |||
There was a problem hiding this comment.
Another weird one where the construct is equivalent but ended up causing scalac to construe this as an existential type
| @@ -2058,7 +2058,7 @@ | |||
| <javacArg>${java.version}</javacArg> | |||
| <javacArg>-target</javacArg> | |||
| <javacArg>${java.version}</javacArg> | |||
| <javacArg>-Xlint:all,-serial,-path</javacArg> | |||
| <javacArg>-Xlint:all,-serial,-path,-try</javacArg> | |||
There was a problem hiding this comment.
Avoids many harmless warnings about not referencing the variable define in try-with-resources
|
Test build #81120 has finished for PR 19051 at commit
|
|
Test build #3901 has finished for PR 19051 at commit
|
|
Test build #3902 has finished for PR 19051 at commit
|
|
Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Aug 25, 2017
## What changes were proposed in this pull request? Fix build warnings and Java lint errors. This just helps a bit in evaluating (new) warnings in another PR I have open. ## How was this patch tested? Existing tests Author: Sean Owen <sowen@cloudera.com> Closes #19051 from srowen/JavaWarnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix build warnings and Java lint errors. This just helps a bit in evaluating (new) warnings in another PR I have open.
How was this patch tested?
Existing tests