[SPARK-21803] [TEST] Remove the HiveDDLCommandSuite #19015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
reviewed
Aug 22, 2017
| import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType} | ||
|
|
||
|
|
||
| // TODO: merge this with DDLSuite (SPARK-14441) | ||
| class DDLCommandSuite extends PlanTest { | ||
| class DDLCommandSuite extends PlanTest with SharedSQLContext { |
There was a problem hiding this comment.
shall we rename it to DDLParserSuite?
|
LGTM |
|
Test build #80956 has finished for PR 19015 at commit
|
|
Test build #80957 has finished for PR 19015 at commit
|
|
Test build #80973 has finished for PR 19015 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We do not have any Hive-specific parser. It does not make sense to keep a parser-specific test suite
HiveDDLCommandSuite.scalain the Hive package. This PR is to remove it.How was this patch tested?
N/A