Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Bump SparkR and PySpark version to 2.3.0. #18341

Closed
wants to merge 2 commits into from
Closed

[MINOR] Bump SparkR and PySpark version to 2.3.0. #18341

wants to merge 2 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jun 18, 2017 •
edited
Loading

What changes were proposed in this pull request?

#17753 bumps master branch version to 2.3.0-SNAPSHOT, but it seems SparkR and PySpark version were omitted.

ditto of #16488 / #17523

How was this patch tested?

N/A

@HyukjinKwon
Copy link
Member Author

I found this when testing #18335. I thought it is odd that CRAN check generated SparkR_2.2.0.tar.gz in the master. I double checked it now generates SparkR_2.3.0.tar.gz.

@HyukjinKwon
Copy link
Member Author

cc @srowen and @felixcheung

@SparkQA
Copy link

SparkQA commented Jun 18, 2017

Test build #78221 has finished for PR 18341 at commit 5e1bd0a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen approved these changes Jun 18, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this particular field gets auto-updated during the build anyway, IIRC, so it won't matter in the way 2.3.0-SNAPSHOT matters to Maven, but to avoid confusion I think we can update it

@felixcheung
Copy link
Member

+1 with what srowen says.
ditto with python actually https://github.com/apache/spark/blob/master/python/pyspark/version.py
i wonder if we should simply change the release/branch process to update everything

felixcheung
felixcheung reviewed Jun 18, 2017
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but how about updating python too - save one less PR

@HyukjinKwon HyukjinKwon changed the title [MINOR] Bump R version to 2.3.0. [MINOR] Bump SparkR and PySpark version to 2.3.0. Jun 19, 2017
@SparkQA
Copy link

SparkQA commented Jun 19, 2017

Test build #78233 has finished for PR 18341 at commit 713b1b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon you are also welcome to add a note to release-process.md in the spark-website repo, but that's optional (and a separate change of course)

@srowen
Copy link
Member

srowen commented Jun 19, 2017

Merged to master

@asfgit asfgit closed this in 9a145fd Jun 19, 2017
@HyukjinKwon
Copy link
Member Author

Sure, I will do. Thank you.

@HyukjinKwon HyukjinKwon mentioned this pull request Jun 20, 2017
Closed
robert3005 pushed a commit to palantir/spark that referenced this pull request Jun 29, 2017
@HyukjinKwon
[MINOR] Bump SparkR and PySpark version to 2.3.0.
14a28b1 
## What changes were proposed in this pull request?

apache#17753 bumps master branch version to 2.3.0-SNAPSHOT, but it seems SparkR and PySpark version were omitted.

ditto of apache#16488 / apache#17523

## How was this patch tested?

N/A

Author: hyukjinkwon <gurwls223@gmail.com>

Closes apache#18341 from HyukjinKwon/r-version.
@HyukjinKwon HyukjinKwon deleted the r-version branch January 2, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HyukjinKwon @SparkQA @felixcheung @srowen