Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20947][PYTHON] Fix encoding/decoding error in pipe action #18277

Closed
wants to merge 3 commits into from
Closed

[SPARK-20947][PYTHON] Fix encoding/decoding error in pipe action #18277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b13e34
[SPARK-20947][PYTHON] Fix encoding/decoding error in pipe action
Jun 12, 2017
47355e6
[SPARK-20947][PYTHON] Fix encoding/decoding error in pipe action
Jun 12, 2017
8c88595
Merge branch 'fix_pipe_encoding_error' of github.com:chaoslawful/spar…
Jun 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyspark/rdd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ def func(iterator):

def pipe_objs(out):
for obj in iterator:
s = str(obj).rstrip('\n') + '\n'
s = unicode(obj).rstrip('\n') + '\n'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a small test to validate this.

Copy link
Member

@HyukjinKwon HyukjinKwon Jan 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaoslawful, if you are active, we could change \n to u\n to reduce the confusion and don't rely on the implicit conversion between str and unicode.

out.write(s.encode('utf-8'))
out.close()
Thread(target=pipe_objs, args=[pipe.stdin]).start()
Expand Down
7 changes: 7 additions & 0 deletions python/pyspark/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,6 +1175,13 @@ def test_pipe_functions(self):
self.assertRaises(Py4JJavaError, rdd.pipe('grep 4', checkCode=True).collect)
self.assertEqual([], rdd.pipe('grep 4').collect())

def test_pipe_unicode(self):
# Regression test for SPARK-20947
data = [u'\u6d4b\u8bd5', '1']
rdd = self.sc.parallelize(data)
result = rdd.pipe('cat').collect()
self.assertEqual(data, result)


class ProfilerTests(PySparkTestCase):

Expand Down