Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] [SQL] Update the description of spark.sql.files.ignoreCorruptFiles and spark.sql.columnNameOfCorruptRecord #18184

Closed
wants to merge 4 commits into from

Conversation

gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Jun 2, 2017

What changes were proposed in this pull request?

  1. The description of spark.sql.files.ignoreCorruptFiles is not accurate. When the file does not exist, we will issue the error message.
org.apache.spark.sql.AnalysisException: Path does not exist: file:/nonexist/path;
  1. spark.sql.columnNameOfCorruptRecord also affects the CSV format. The current description only mentions JSON format.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @cloud-fan @sameeragarwal @ueshin

@SparkQA
Copy link

SparkQA commented Jun 2, 2017

Test build #77668 has started for PR 18184 at commit fc37005.

@gatorsmile gatorsmile changed the title [MINOR] [SQL] Update the description of spark.sql.files.ignoreCorruptFiles [MINOR] [SQL] Update the description of spark.sql.files.ignoreCorruptFiles and spark.sql.columnNameOfCorruptRecord Jun 2, 2017
@SparkQA
Copy link

SparkQA commented Jun 2, 2017

Test build #77670 has started for PR 18184 at commit 5bde17e.

@cloud-fan
Copy link
Contributor

retest this please

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jun 2, 2017

Test build #77680 has finished for PR 18184 at commit 5bde17e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sameeragarwal
Copy link
Member

LGTM

@cloud-fan
Copy link
Contributor

thanks, merging to master/2.2!

asfgit pushed a commit that referenced this pull request Jun 2, 2017
…iles and spark.sql.columnNameOfCorruptRecord

### What changes were proposed in this pull request?
1. The description of `spark.sql.files.ignoreCorruptFiles` is not accurate. When the file does not exist, we will issue the error message.
```
org.apache.spark.sql.AnalysisException: Path does not exist: file:/nonexist/path;
```

2. `spark.sql.columnNameOfCorruptRecord` also affects the CSV format. The current description only mentions JSON format.

### How was this patch tested?
N/A

Author: Xiao Li <gatorsmile@gmail.com>

Closes #18184 from gatorsmile/updateMessage.

(cherry picked from commit 2a780ac)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@asfgit asfgit closed this in 2a780ac Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants