[SPARK-20942][WEB-UI]The title style about field is error in the history server web ui. #18170
Conversation
…ucceeded|failed|unknown]
…remove redundant description.
…d should not contain ''Event Log ' field in the history server web ui.
|
@srowen @ajbozarth @jerryshao Help to review the code, thanks. |
| @@ -195,7 +195,7 @@ $(document).ready(function() { | |||
| } | |||
|
|
|||
| $(selector).DataTable(conf); | |||
| $('#hisotry-summary [data-toggle="tooltip"]').tooltip(); | |||
| $('#history-summary-table [data-toggle="tooltip"]').tooltip(); | |||
There was a problem hiding this comment.
Just #history-summary is still correct here, but nice catch on the spelling error.
There was a problem hiding this comment.
The original is the spelling error. I did not notice that I thought it was ID wrong. I will fix it and test it.
There was a problem hiding this comment.
I have fixed the spelling error. The test result is OK. But historypage-template.html still need to be modified. Thanks.
| App Name | ||
| </span> | ||
| </th> | ||
| <th class="attemptIDSpan"> | ||
| <span data-toggle="tooltip" data-placement="above" title="The attempt ID of this application since one application might be launched several times"> | ||
| <span data-toggle="tooltip" data-placement="right" title="The attempt ID of this application since one application might be launched several times"> |
There was a problem hiding this comment.
Why we need to change the tooltip placement to "right", any particular issue here?
There was a problem hiding this comment.
The tooltip placement to "above", the prompt position will always be displayed on the APP ID, rather than on the current title.
There was a problem hiding this comment.
ah I found the issue, above is incorrect, what we want is top
There was a problem hiding this comment.
I will fix it and test it. Thanks.
There was a problem hiding this comment.
I have fixed the error. ‘top’ replace ‘above’. The test result is OK. Thanks.
| App ID | ||
| </span> | ||
| </th> | ||
| <th> | ||
| <span data-toggle="tooltip" data-placement="above" title="Name of the application."> | ||
| <span data-toggle="tooltip" data-placement="right" title="Name of this application."> |
There was a problem hiding this comment.
I don't see a reason to change this
There was a problem hiding this comment.
Hello, you mean, 'the application' is changed to 'this application'? Or 'above' to 'right'?
First, consistent with other field titles.
Second, The tooltip placement to "above", the prompt position will always be displayed on the APP ID, rather than on the current title.
|
@ajbozarth |
|
Test build #3770 has finished for PR 18170 at commit
|
|
Merged to master/2.2 |
…tory server web ui. ## What changes were proposed in this pull request? 1.The title style about field is error. fix before:  fix after:   executor-page style:  2.Title text description, 'the application' should be changed to 'this application'. 3.Analysis of code: $('#history-summary [data-toggle="tooltip"]').tooltip(); The id of 'history-summary' is not there. We only contain id of 'history-summary-table'. ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <guo.xiaolong1@zte.com.cn> Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn> Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn> Closes #18170 from guoxiaolongzte/SPARK-20942. (cherry picked from commit 625cebf) Signed-off-by: Sean Owen <sowen@cloudera.com>
What changes were proposed in this pull request?
1.The title style about field is error.
fix before:
fix after:
executor-page style:
2.Title text description, 'the application' should be changed to 'this application'.
3.Analysis of code:
$('#history-summary [data-toggle="tooltip"]').tooltip();
The id of 'history-summary' is not there. We only contain id of 'history-summary-table'.
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.