[SPARK-20941] [SQL] Fix SubqueryExec Reuse #18169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #77609 has finished for PR 18169 at commit
|
cloud-fan
reviewed
Jun 1, 2017
| @@ -25,6 +25,7 @@ import org.apache.spark.sql.catalyst.errors._ | |||
| import org.apache.spark.sql.catalyst.expressions._ | |||
| import org.apache.spark.sql.catalyst.expressions.aggregate._ | |||
| import org.apache.spark.sql.catalyst.expressions.codegen._ | |||
| import org.apache.spark.sql.catalyst.plans.QueryPlan | |||
cloud-fan
reviewed
Jun 1, 2017
| @@ -700,6 +703,33 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext { | |||
| row => Seq.fill(16)(Row.merge(row, row))).collect().toSeq) | |||
| } | |||
|
|
|||
| test("Verify spark.sql.subquery.reuse") { | |||
| Seq("true", "false").foreach { reuse => | |||
| withSQLConf(SQLConf.SUBQUERY_REUSE_ENABLED.key -> reuse) { | |||
There was a problem hiding this comment.
nit: it's more natural to use Seq(true, false) and then do reuse.toString here.
cloud-fan
reviewed
Jun 1, 2017
| test("Verify spark.sql.subquery.reuse") { | ||
| Seq("true", "false").foreach { reuse => | ||
| withSQLConf(SQLConf.SUBQUERY_REUSE_ENABLED.key -> reuse) { | ||
| val df = sql( |
There was a problem hiding this comment.
it will be good if we also check result of this df
|
retest this please |
|
LGTM |
|
Test build #77629 has finished for PR 18169 at commit
|
|
Test build #77630 has finished for PR 18169 at commit
|
|
Test build #77633 has finished for PR 18169 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2017
Before this PR, Subquery reuse does not work. Below are three issues: - Subquery reuse does not work. - It is sharing the same `SQLConf` (`spark.sql.exchange.reuse`) with the one for Exchange Reuse. - No test case covers the rule Subquery reuse. This PR is to fix the above three issues. - Ignored the physical operator `SubqueryExec` when comparing two plans. - Added a dedicated conf `spark.sql.subqueries.reuse` for controlling Subquery Reuse - Added a test case for verifying the behavior N/A Author: Xiao Li <gatorsmile@gmail.com> Closes #18169 from gatorsmile/subqueryReuse. (cherry picked from commit f7cf209) Signed-off-by: Xiao Li <gatorsmile@gmail.com>
|
Thanks! Merging to master/2.2 |
|
@gatorsmile , why was this reverted? Are you going to open another PR to fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before this PR, Subquery reuse does not work. Below are three issues:
SQLConf(spark.sql.exchange.reuse) with the one for Exchange Reuse.This PR is to fix the above three issues.
SubqueryExecwhen comparing two plans.spark.sql.subqueries.reusefor controlling Subquery ReuseHow was this patch tested?
N/A