Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20876][SQL][Backport-2.2]If the input parameter is float type for ceil or floor,the result is not we expected #18155

Closed
wants to merge 1 commit into from
Closed

[SPARK-20876][SQL][Backport-2.2]If the input parameter is float type for ceil or floor,the result is not we expected #18155

wants to merge 1 commit into from

Conversation

10110346
Copy link
Contributor

@10110346 10110346 commented May 31, 2017 •
edited
Loading

What changes were proposed in this pull request?

This PR is to backport #18103 to Spark 2.2

How was this patch tested?

unit test

@ueshin
Copy link
Member

ueshin commented May 31, 2017

ok to test

@SparkQA
Copy link

SparkQA commented May 31, 2017

Test build #77573 has started for PR 18155 at commit 5ab4a96.

@ueshin
Copy link
Member

ueshin commented May 31, 2017

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented May 31, 2017

Test build #77579 has finished for PR 18155 at commit 6fc66e8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member

ueshin commented May 31, 2017

LGTM, cc @gatorsmile

@SparkQA
Copy link

SparkQA commented May 31, 2017

Test build #77580 has finished for PR 18155 at commit 6fc66e8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gatorsmile
gatorsmile approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

asfgit pushed a commit that referenced this pull request May 31, 2017
@10110346 @gatorsmile
[SPARK-20876][SQL][BACKPORT-2.2] If the input parameter is float type…
f59f9a3 
… for ceil or floor,the result is not we expected

## What changes were proposed in this pull request?

This PR is to backport #18103 to Spark 2.2

## How was this patch tested?
unit test

Author: liuxian <liu.xian3@zte.com.cn>

Closes #18155 from 10110346/wip-lx-0531.
@gatorsmile
Copy link
Member

Thanks! Merging to 2.0.

Could you manually close this PR? Thanks!

@10110346
Copy link
Contributor Author

10110346 commented Jun 1, 2017

@gatorsmile OK,thanks

@10110346 10110346 closed this Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@10110346 @ueshin @SparkQA @gatorsmile