[SPARK-19236][SQL][FOLLOW-UP] Added createOrReplaceGlobalTempView method #18147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyspark/sql/dataframe.py
Outdated
| >>> df.createOrReplaceGlobalTempView("people") | ||
| >>> df2 = df.filter(df.age > 3) | ||
| >>> df2.createOrReplaceGlobalTempView("people") | ||
| >>> df3 = spark.sql("select * from people") |
There was a problem hiding this comment.
df3 = spark.sql("select * from global_temp.people")?
|
Test build #77552 has finished for PR 18147 at commit
|
gatorsmile
commented
May 31, 2017
| // We can also use Catalog API to drop global temp view | ||
| spark.catalog.dropGlobalTempView("src2") | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src2")) | ||
| // We can also use Dataset API to replace global temp view |
There was a problem hiding this comment.
The code added are line 38 and line 73-78
|
Test build #77563 has finished for PR 18147 at commit
|
cloud-fan
reviewed
May 31, 2017
| @@ -191,6 +191,23 @@ def createGlobalTempView(self, name): | |||
| """ | |||
| self._jdf.createGlobalTempView(name) | |||
|
|
|||
| @since(2.2) | |||
There was a problem hiding this comment.
we didn't merge the original PR to 2.2 right?
There was a problem hiding this comment.
See the backport PR #18167
|
LGTM except for @cloud-fan's comment. |
|
thanks, merging to master! |
asfgit
pushed a commit
that referenced
this pull request
Jun 2, 2017
…method ### What changes were proposed in this pull request? This PR is to backport two PRs for adding the `createOrReplaceGlobalTempView` method #18147 #16598 --- Added the createOrReplaceGlobalTempView method for dataset API ### How was this patch tested? N/A Author: Xiao Li <gatorsmile@gmail.com> Closes #18167 from gatorsmile/Backport18147.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR does the following tasks:
How was this patch tested?
Added test cases to both Scala and Python