Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT-2.2][SPARK-19372][SQL] Fix throwing a Java exception at df.fliter() due to 64KB bytecode size limit #18119

Closed
wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented May 26, 2017

What changes were proposed in this pull request?

This PR is backport of #17087 to Spark 2.2

How was this patch tested?

Add a test suite into DataFrameSuite

@SparkQA
Copy link

SparkQA commented May 26, 2017

Test build #77419 has finished for PR 18119 at commit e39bda0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class InterpretedPredicate(expression: Expression) extends BasePredicate

@kiszk
Copy link
Member Author

kiszk commented May 26, 2017

ping @zsxwing

@marmbrus
Copy link
Contributor

Since this is purely a fallback for a case that would error, it seems possibly okay to include in 2.2. @zsxwing could you take a look and make sure I'm right?

@zsxwing
Copy link
Member

zsxwing commented May 26, 2017

@kiszk I just pushed #17087 directly to branch-2.2 since there is no conflict. Could you close this one?

In addition, I noticed that the test outputs too many logs, could you submit a PR to use testQuietly instead?

@kiszk
Copy link
Member Author

kiszk commented May 27, 2017

@zsxwing , sure, I submit another PR.

@kiszk kiszk closed this May 27, 2017
@dongjoon-hyun
Copy link
Member

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants