Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2886] Use more specific actor system name than "spark" #1810

Closed
wants to merge 6 commits into from
Closed

[SPARK-2886] Use more specific actor system name than "spark" #1810

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f644b55
Use more specific service name
andrewor14 Aug 6, 2014
1c1b42e
Avoid spaces in akka system name
andrewor14 Aug 6, 2014
c8c6a62
Do not include hyphens in actor name
andrewor14 Aug 8, 2014
921363e
Merge branch 'master' of github.com:apache/spark into service-name
andrewor14 Aug 14, 2014
3a92843
Change actor name to sparkDriver and sparkExecutor
andrewor14 Aug 14, 2014
8c459ed
Use a common variable for driver/executor actor system names
andrewor14 Aug 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/scala/org/apache/spark/SparkEnv.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ object SparkEnv extends Logging {
}

val securityManager = new SecurityManager(conf)

val (actorSystem, boundPort) = AkkaUtils.createActorSystem("spark", hostname, port, conf = conf,
securityManager = securityManager)
val actorSystemName = if (isDriver) "driverActor" else "executorActor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this "driver actor system" / "executor actor system"? These are not individual actors, but whole systems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm looks like elsewhere we call this sparkMaster and sparkWorker, so maybe I'll keep this consistent by calling these sparkDriver and sparkExecutor. Also the akka URL looks weird if we include "*ActorSystem" in it, e.g. akka.tcp://driverActorSystem@localhost:7077

val (actorSystem, boundPort) = AkkaUtils.createActorSystem(
actorSystemName, hostname, port, conf, securityManager)

// Figure out which port Akka actually bound to in case the original port is 0 or occupied.
// This is so that we tell the executors the correct port to connect to.
Expand Down