[Spark18045][MLlib]updated the information sending to usr._2 #18045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think updated information of updateY incorrectly send to source vertice. the original code like the below.
ctx.sendToSrc((updateP, updateY, (err - conf.gamma6 * usr._3) * conf.gamma1))
In fact, usr._2 store pu + |N(u)|^(-0.5)*sum(y).
we have already updated the part of y in usr._2 through sending the message to destination vertex, and this method will effect the part of y in usr._2,
but the part of pu is never updated. so we should send updateP to source vertex not updateY.
|
Can one of the admins verify this patch? |
|
Please read http://spark.apache.org/contributing.html and fix the title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think updated information of updateY incorrectly send to source vertice. the original code like the below.
ctx.sendToSrc((updateP, updateY, (err - conf.gamma6 * usr._3) * conf.gamma1))
In fact, usr._2 store pu + |N(u)|^(-0.5)*sum(y).
we have already updated the part of y in usr._2 through sending the message to destination vertex, and this method will effect the part of y in usr._2,
but the part of pu is never updated. so we should send updateP to source vertex not updateY.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.