Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20567] Lazily bind in GenerateExec #17838

Closed
wants to merge 1 commit into from
Closed

[SPARK-20567] Lazily bind in GenerateExec #17838

wants to merge 1 commit into from

Conversation

marmbrus
Copy link
Contributor

@marmbrus marmbrus commented May 3, 2017

It is not valid to eagerly bind with the child's output as this causes failures when we attempt to canonicalize the plan (replacing the attribute references with dummies).

@brkyvz
Copy link
Contributor

brkyvz commented May 3, 2017

LGTM!

@SparkQA
Copy link

SparkQA commented May 3, 2017

Test build #76399 has finished for PR 17838 at commit 7c86b0e.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor

brkyvz commented May 3, 2017

retest this please

@SparkQA
Copy link

SparkQA commented May 3, 2017

Test build #76405 has finished for PR 17838 at commit 7c86b0e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM - merging to master/2.2

asfgit pushed a commit that referenced this pull request May 3, 2017
@marmbrus @hvanhovell
[SPARK-20567] Lazily bind in GenerateExec
c80242a 
It is not valid to eagerly bind with the child's output as this causes failures when we attempt to canonicalize the plan (replacing the attribute references with dummies).

Author: Michael Armbrust <michael@databricks.com>

Closes #17838 from marmbrus/fixBindExplode.

(cherry picked from commit 6235132)
Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>
@asfgit asfgit closed this in 6235132 May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marmbrus @brkyvz @SparkQA @hvanhovell