[SPARK-20523][BUILD] Clean up build warnings for 2.2.0 release #17803
Conversation
… "ProcessingTime" method name and Java style problems
| @@ -37,7 +37,9 @@ | |||
| * `map/flatMapGroupsWithState` by calling `GroupState.setTimeoutDuration()`. See documentation | |||
| * on `GroupState` for more details. | |||
| */ | |||
| public static GroupStateTimeout ProcessingTimeTimeout() { return ProcessingTimeTimeout$.MODULE$; } | |||
| public static GroupStateTimeout processingTimeTimeout() { | |||
There was a problem hiding this comment.
CC @tdas this especially would need your attention. The name of the method, being TitleCase instead of camelCase, generates a Java style error. It has a point. We can change it because these methods are only new in 2.2, but wanted to check that it is OK? or was it on purpose and needs to be suppressed?
There was a problem hiding this comment.
That's on purpose to provide more consistent APIs for Scala and Java. Let's just suppress them.
There was a problem hiding this comment.
Thanks @zsxwing let me try to back this out and suppress
|
Test build #76269 has finished for PR 17803 at commit
|
|
Test build #76360 has finished for PR 17803 at commit
|
|
LGTM from MLlib side, I was planing to make this cleanup after upgrading breeze, but didn't find time slot. Thanks very much for your work. |
|
I don't know graphx or mllib. Others look good to me. |
## What changes were proposed in this pull request? Fix build warnings primarily related to Breeze 0.13 operator changes, Java style problems ## How was this patch tested? Existing tests Author: Sean Owen <sowen@cloudera.com> Closes #17803 from srowen/SPARK-20523. (cherry picked from commit 16fab6b) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.2 |
## What changes were proposed in this pull request? Fix build warnings primarily related to Breeze 0.13 operator changes, Java style problems ## How was this patch tested? Existing tests Author: Sean Owen <sowen@cloudera.com> Closes #17803 from srowen/SPARK-20523.
What changes were proposed in this pull request?
Fix build warnings primarily related to Breeze 0.13 operator changes, Java style problems
How was this patch tested?
Existing tests