[SPARK-20518][CORE]Supplement the new blockidsuite unit tests #17794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
May 2, 2017
| @@ -19,6 +19,8 @@ package org.apache.spark.storage | |||
|
|
|||
| import org.apache.spark.SparkFunSuite | |||
|
|
|||
| import java.util.UUID | |||
There was a problem hiding this comment.
The import ordering is not correct, it should be:
java packages
scala packages
third-party packages
spark packages
jerryshao
reviewed
May 2, 2017
| @@ -101,6 +129,30 @@ class BlockIdSuite extends SparkFunSuite { | |||
| assertSame(id, BlockId(id.toString)) | |||
| } | |||
|
|
|||
| test("temp local") { | |||
| val id = TempLocalBlockId(new UUID(5,2)) | |||
|
Would you please update the title to add |
|
@jerryshao |
|
The change LGTM, I think test PRs are always welcome. CC @srowen to see committer's comment. |
srowen
approved these changes
May 3, 2017
|
Test build #3691 has finished for PR 17794 at commit
|
|
retest this please |
|
Test build #76499 has finished for PR 17794 at commit
|
srowen
approved these changes
May 6, 2017
|
Merged to master |
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? This PR adds the new unit tests to support ShuffleDataBlockId , ShuffleIndexBlockId , TempShuffleBlockId , TempLocalBlockId ## How was this patch tested? The new unit test. Author: caoxuewen <cao.xuewen@zte.com.cn> Closes apache#17794 from heary-cao/blockidsuite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the new unit tests to support ShuffleDataBlockId , ShuffleIndexBlockId , TempShuffleBlockId , TempLocalBlockId
How was this patch tested?
The new unit test.