[SPARK-20291][SQL][BACKPORT] NaNvl(FloatType, NullType) should not be cast to N… #17618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #75731 has started for PR 17618 at commit |
|
Shall we add backport tag to the title? |
|
Test build #75732 has started for PR 17618 at commit |
|
@viirya Added. Thanks. |
|
retest this please |
|
Test build #75734 has finished for PR 17618 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Apr 12, 2017
… cast to N… …aNvl(DoubleType, DoubleType) ## What changes were proposed in this pull request? This is a backport of #17606 `NaNvl(float value, null)` will be converted into `NaNvl(float value, Cast(null, DoubleType))` and finally `NaNvl(Cast(float value, DoubleType), Cast(null, DoubleType))`. This will cause mismatching in the output type when the input type is float. By adding extra rule in TypeCoercion can resolve this issue. ## How was this patch tested? unite tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: DB Tsai <dbt@netflix.com> Author: DB Tsai <dbtsai@dbtsai.com> Closes #17618 from dbtsai/branch-2.0.
gatorsmile
approved these changes
Apr 12, 2017
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aNvl(DoubleType, DoubleType)
What changes were proposed in this pull request?
This is a backport of #17606
NaNvl(float value, null)will be converted intoNaNvl(float value, Cast(null, DoubleType))and finallyNaNvl(Cast(float value, DoubleType), Cast(null, DoubleType)).This will cause mismatching in the output type when the input type is float.
By adding extra rule in TypeCoercion can resolve this issue.
How was this patch tested?
unite tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.