[SPARK-19025][SQL] Remove SQL builder for operators #16869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #72636 has finished for PR 16869 at commit
|
|
LGTM. I'd like to wait a little with merging this in order to build some consensus. |
|
I had an offline discussion with @rxin about this, and we have decided to merge this one. |
|
Now, we can also remove the generated sqlgen files. |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? With the new approach of view resolution, we can get rid of SQL generation on view creation, so let's remove SQL builder for operators. Note that, since all sql generation for operators is defined in one file (org.apache.spark.sql.catalyst.SQLBuilder), it’d be trivial to recover it in the future. ## How was this patch tested? N/A Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#16869 from jiangxb1987/SQLBuilder.
This was referenced Aug 24, 2017
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Aug 25, 2017
## What changes were proposed in this pull request? After [SPARK-19025](apache#16869), there is no need to keep SQLBuilderTest. ExpressionSQLBuilderSuite is the only place to use it. This PR aims to remove SQLBuilderTest. ## How was this patch tested? Pass the updated `ExpressionSQLBuilderSuite`. Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#19044 from dongjoon-hyun/SPARK-21832.
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Aug 26, 2017
…g in HiveCompatibilitySuite ## What changes were proposed in this pull request? [SPARK-19025](apache#16869) removes SQLBuilder, so we don't need the following in HiveCompatibilitySuite. ```scala // Ensures that the plans generation use metastore relation and not OrcRelation // Was done because SqlBuilder does not work with plans having logical relation TestHive.setConf(HiveUtils.CONVERT_METASTORE_ORC, false) ``` ## How was this patch tested? Pass the existing Jenkins tests. Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#19043 from dongjoon-hyun/SPARK-21831.
|
"With the new approach of view resolution, we can get rid of SQL generation on view creation, so let's remove SQL builder for operators." can you introduce more abount "view resolution"? In my situation, I will use spark with logicalplan optimizer to build better logicalplan, and transfer this logicalplan back to sql for executing outside by spark, such as odps in alibaba etc. so, can you give me some suggestion for my task? thanks very much! |
|
@gatorsmile @ hvanhovell @rxin @ @yhuai |
hvanhovell
pushed a commit
that referenced
this pull request
May 10, 2023
…QL`, `outputRowFormatSQL` method ### What changes were proposed in this pull request? Remove useless code in class `ScriptInputOutputSchema`. Include `getRowFormatSQL`, `inputRowFormatSQL`, `outputRowFormatSQL` method. It unused when #16869 ### Why are the changes needed? Clear code. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unnecessary. Closes #41063 from Hisoka-X/remove_useless_code. Authored-by: Hisoka <fanjiaeminem@qq.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With the new approach of view resolution, we can get rid of SQL generation on view creation, so let's remove SQL builder for operators.
Note that, since all sql generation for operators is defined in one file (org.apache.spark.sql.catalyst.SQLBuilder), it’d be trivial to recover it in the future.
How was this patch tested?
N/A