[SPARK-17832][SQL] TableIdentifier.quotedString creates un-parseable names when name contains a backtick #15403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Besides, we have similar problem in |
|
Test build #66576 has finished for PR 15403 at commit
|
hvanhovell
reviewed
Oct 8, 2016
| } | ||
|
|
||
| def unquotedString: String = { | ||
| if (database.isDefined) s"${database.get}.$identifier" else identifier |
There was a problem hiding this comment.
I think we should keep unquotedString this as it is. That gives some a more readable (less parseable) version of the identifier. I just added an example with unquotedIdentifier to show that there was no way to get a parseable string from the table identifier.
hvanhovell
reviewed
Oct 8, 2016
|
|
||
| test("SPARK-17832 table identifier - contains backtick") { | ||
| val complexName = TableIdentifier("`weird`table`name", Some("`d`b`1")) | ||
| assert(TableIdentifier("`weird`table`name", Some("`d`b`1")) === |
There was a problem hiding this comment.
Use complexName? Why create the identifier twice?
|
@jiangxb1987 This looks pretty good. What is the problem |
|
@hvanhovell nvm about the |
|
Test build #66596 has finished for PR 15403 at commit
|
|
LGTM - merging to master/2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Oct 10, 2016
…names when name contains a backtick
## What changes were proposed in this pull request?
The `quotedString` method in `TableIdentifier` and `FunctionIdentifier` produce an illegal (un-parseable) name when the name contains a backtick. For example:
```
import org.apache.spark.sql.catalyst.parser.CatalystSqlParser._
import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute
val complexName = TableIdentifier("`weird`table`name", Some("`d`b`1"))
parseTableIdentifier(complexName.unquotedString) // Does not work
parseTableIdentifier(complexName.quotedString) // Does not work
parseExpression(complexName.unquotedString) // Does not work
parseExpression(complexName.quotedString) // Does not work
```
We should handle the backtick properly to make `quotedString` parseable.
## How was this patch tested?
Add new testcases in `TableIdentifierParserSuite` and `ExpressionParserSuite`.
Author: jiangxingbo <jiangxb1987@gmail.com>
Closes #15403 from jiangxb1987/backtick.
(cherry picked from commit 26fbca4)
Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…names when name contains a backtick
## What changes were proposed in this pull request?
The `quotedString` method in `TableIdentifier` and `FunctionIdentifier` produce an illegal (un-parseable) name when the name contains a backtick. For example:
```
import org.apache.spark.sql.catalyst.parser.CatalystSqlParser._
import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute
val complexName = TableIdentifier("`weird`table`name", Some("`d`b`1"))
parseTableIdentifier(complexName.unquotedString) // Does not work
parseTableIdentifier(complexName.quotedString) // Does not work
parseExpression(complexName.unquotedString) // Does not work
parseExpression(complexName.quotedString) // Does not work
```
We should handle the backtick properly to make `quotedString` parseable.
## How was this patch tested?
Add new testcases in `TableIdentifierParserSuite` and `ExpressionParserSuite`.
Author: jiangxingbo <jiangxb1987@gmail.com>
Closes apache#15403 from jiangxb1987/backtick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
quotedStringmethod inTableIdentifierandFunctionIdentifierproduce an illegal (un-parseable) name when the name contains a backtick. For example:We should handle the backtick properly to make
quotedStringparseable.How was this patch tested?
Add new testcases in
TableIdentifierParserSuiteandExpressionParserSuite.