[SPARK-17782][STREAMING][KAFKA] alternative eliminate race condition of poll twice #15401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g called twice and moving position
…tiple topicpartitions
|
Test build #66559 has finished for PR 15401 at commit
|
|
Test build #66562 has finished for PR 15401 at commit
|
|
@koeninger sorry for the delay. Actually, my concern is |
|
@zsxwing so poll is only called in consumer strategy in situations in which starting offsets have been provided, and seek is called immediately thereafter for those offsets. What is the specific concern at that point? If you want me to make paranoidPoll a static method and call it from consumer offsets as well I can, but.... |
|
@koeninger Sorry. I didn't notice the |
asfgit
pushed a commit
that referenced
this pull request
Oct 12, 2016
…of poll twice ## What changes were proposed in this pull request? Alternative approach to #15387 Author: cody koeninger <cody@koeninger.org> Closes #15401 from koeninger/SPARK-17782-alt. (cherry picked from commit f9a56a1) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…of poll twice ## What changes were proposed in this pull request? Alternative approach to apache#15387 Author: cody koeninger <cody@koeninger.org> Closes apache#15401 from koeninger/SPARK-17782-alt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Alternative approach to #15387