Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17738] [TEST] Fix flaky test in ColumnTypeSuite #15395

Closed
wants to merge 1 commit into from

Conversation

davies
Copy link
Contributor

@davies davies commented Oct 7, 2016

What changes were proposed in this pull request?

The default buffer size is not big enough for randomly generated MapType.

How was this patch tested?

Ran the tests in 100 times, it never fail (it fail 8 times before the patch).

@davies
Copy link
Contributor Author

davies commented Oct 7, 2016

@zsxwing

@SparkQA
Copy link

SparkQA commented Oct 7, 2016

Test build #66531 has finished for PR 15395 at commit 52b2b7d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Oct 8, 2016

JVM crash?

@kiszk
Copy link
Member

kiszk commented Oct 10, 2016

@davies I appreciate your efforts. I should have noticed this.

@SparkQA
Copy link

SparkQA commented Oct 10, 2016

Test build #3317 has finished for PR 15395 at commit 52b2b7d.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor Author

davies commented Oct 10, 2016

@zsxwing Should I merge this one to make the jenkins happy?

@zsxwing
Copy link
Member

zsxwing commented Oct 10, 2016

retest this please.

This one has not yet passed.

@davies
Copy link
Contributor Author

davies commented Oct 10, 2016

@zsxwing All tests passed in previous try: https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3317/consoleFull, I kicked another.

@SparkQA
Copy link

SparkQA commented Oct 11, 2016

Test build #3320 has finished for PR 15395 at commit 52b2b7d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Oct 11, 2016

LGTM. Merging to master and 2.0.

asfgit pushed a commit that referenced this pull request Oct 11, 2016
## What changes were proposed in this pull request?

The default buffer size is not big enough for randomly generated MapType.

## How was this patch tested?

Ran the tests in 100 times, it never fail (it fail 8 times before the patch).

Author: Davies Liu <davies@databricks.com>

Closes #15395 from davies/flaky_map.

(cherry picked from commit d5ec4a3)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
@asfgit asfgit closed this in d5ec4a3 Oct 11, 2016
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

The default buffer size is not big enough for randomly generated MapType.

## How was this patch tested?

Ran the tests in 100 times, it never fail (it fail 8 times before the patch).

Author: Davies Liu <davies@databricks.com>

Closes apache#15395 from davies/flaky_map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants