[SPARK-17707] [WEBUI] Web UI prevents spark-submit application to be finished #15381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #66458 has finished for PR 15381 at commit
|
zsxwing
reviewed
Oct 7, 2016
| @@ -90,8 +95,21 @@ public void run() { | |||
| Arrays.toString(sslContextFactory.getExcludeProtocols())); | |||
| sslContextFactory.setKeyStorePath(keyStorePath); | |||
| sslContextFactory.setKeyStorePassword(keyStorePassword); | |||
| connector = new ServerConnector(httpServer, sslContextFactory); | |||
| connectionFactories = AbstractConnectionFactory.getFactories( | |||
There was a problem hiding this comment.
This will expose both http and https, and it's a behavior change. Right?
There was a problem hiding this comment.
I don't think so just because I copied it from the Jetty constructor that was already being called in this path:
/* ------------------------------------------------------------ */
/** HTTP Server Connection.
* <p>Construct a ServerConnector with a private instance of {@link HttpConnectionFactory} as the primary protocol</p>.
* @param server The {@link Server} this connector will accept connection for.
* @param sslContextFactory If non null, then a {@link SslConnectionFactory} is instantiated and prepended to the
* list of HTTP Connection Factory.
*/
public ServerConnector(
@Name("server") Server server,
@Name("sslContextFactory") SslContextFactory sslContextFactory)
{
this(server,null,null,null,-1,-1,AbstractConnectionFactory.getFactories(sslContextFactory,new HttpConnectionFactory()));
}
However if this wasn't actually the intended behavior we can change it of course.
|
LGTM. Merging to master and 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Oct 7, 2016
…inished This expands calls to Jetty's simple `ServerConnector` constructor to explicitly specify a `ScheduledExecutorScheduler` that makes daemon threads. It should otherwise result in exactly the same configuration, because the other args are copied from the constructor that is currently called. (I'm not sure we should change the Hive Thriftserver impl, but I did anyway.) This also adds `sc.stop()` to the quick start guide example. Existing tests; _pending_ at least manual verification of the fix. Author: Sean Owen <sowen@cloudera.com> Closes #15381 from srowen/SPARK-17707. (cherry picked from commit cff5607) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
|
FYI, I fixed import conflicts in JettyUtils manually for branch-2.0. |
abridgett
pushed a commit
to opensignal/spark
that referenced
this pull request
Oct 10, 2016
…inished This expands calls to Jetty's simple `ServerConnector` constructor to explicitly specify a `ScheduledExecutorScheduler` that makes daemon threads. It should otherwise result in exactly the same configuration, because the other args are copied from the constructor that is currently called. (I'm not sure we should change the Hive Thriftserver impl, but I did anyway.) This also adds `sc.stop()` to the quick start guide example. Existing tests; _pending_ at least manual verification of the fix. Author: Sean Owen <sowen@cloudera.com> Closes apache#15381 from srowen/SPARK-17707.
|
Thanks for fixing this issue. It works in 2.0.2 now. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…inished ## What changes were proposed in this pull request? This expands calls to Jetty's simple `ServerConnector` constructor to explicitly specify a `ScheduledExecutorScheduler` that makes daemon threads. It should otherwise result in exactly the same configuration, because the other args are copied from the constructor that is currently called. (I'm not sure we should change the Hive Thriftserver impl, but I did anyway.) This also adds `sc.stop()` to the quick start guide example. ## How was this patch tested? Existing tests; _pending_ at least manual verification of the fix. Author: Sean Owen <sowen@cloudera.com> Closes apache#15381 from srowen/SPARK-17707.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This expands calls to Jetty's simple
ServerConnectorconstructor to explicitly specify aScheduledExecutorSchedulerthat makes daemon threads. It should otherwise result in exactly the same configuration, because the other args are copied from the constructor that is currently called.(I'm not sure we should change the Hive Thriftserver impl, but I did anyway.)
This also adds
sc.stop()to the quick start guide example.How was this patch tested?
Existing tests; pending at least manual verification of the fix.