-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-17782][STREAMING][BUILD] Add Kafka 0.10 project to build modules #15355
Conversation
cc @koeninger any idea why this flaky? |
I have generally been unable to reproduce these kinds of test failures on my local environment, and don't have access to the build server, so trying fix without repro is pretty much shooting randomly in the dark. It does seem unfortunate to me that we're effectively doing full integration tests on every PR, even if a patch has changed something (e.g. MLLib) that couldn't possibly affect the modules in /external |
Test build #66361 has finished for PR 15355 at commit
|
Actually we do have the infra to not run these tests if it is just an unrelated module change. Was those not setup for Kafka? |
Good point, I don't see separate config for the 0.10 module in |
Test build #66461 has finished for PR 15355 at commit
|
Test build #66463 has finished for PR 15355 at commit
|
@koeninger you can download the unit test logs from https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6/1756/artifact/ I saw the offsets of the first batch (pat1 0 16 16 should be pat1 0 0 16) was wrong in the unit test logs:
Seems the |
@zsxwing good eye, thanks. It's not that auto.offset.reset.earliest doesn't work, it's that there's a potential race condition that poll gets called twice slowly enough for consumer position to be modified before topicpartitions are paused. should address that. It's something that whoever works on the duplicated equivalent code in the structured streaming module is going to have to address, also. |
I have re-enables the kafka test. This PR now only contains a change to build infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and will merge as soon as it passes, though the actual fix will be in the other PR.
Test build #66487 has finished for PR 15355 at commit
|
Merged to master |
## What changes were proposed in this pull request? This PR adds the Kafka 0.10 subproject to the build infrastructure. This makes sure Kafka 0.10 tests are only triggers when it or of its dependencies change. Author: Herman van Hovell <hvanhovell@databricks.com> Closes #15355 from hvanhovell/SPARK-17782.
Also check-picked this one into branch 2.0 since it's also helpful for 2.0 backport PRs. |
## What changes were proposed in this pull request? This PR adds the Kafka 0.10 subproject to the build infrastructure. This makes sure Kafka 0.10 tests are only triggers when it or of its dependencies change. Author: Herman van Hovell <hvanhovell@databricks.com> Closes apache#15355 from hvanhovell/SPARK-17782.
What changes were proposed in this pull request?
This PR adds the Kafka 0.10 subproject to the build infrastructure. This makes sure Kafka 0.10 tests are only triggers when it or of its dependencies change.