Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark 2557] fix LOCAL_N_REGEX in createTaskScheduler and make local-n and local-n-failures consistent #1464

Closed
wants to merge 2 commits into from
Closed

[Spark 2557] fix LOCAL_N_REGEX in createTaskScheduler and make local-n and local-n-failures consistent #1464

wants to merge 2 commits into from

Conversation

advancedxy
Copy link
Contributor

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

/cc @aarondav

@advancedxy
Copy link
Contributor Author

ping. @aarondav what do you think?

@advancedxy
Copy link
Contributor Author

Well, could someone review this pr? Or should I close this pr?

@aarondav
Copy link
Contributor

aarondav commented Aug 1, 2014

This seems totally reasonable, apologies for not seeing this. LGTM once Jenkins passes.

@aarondav
Copy link
Contributor

aarondav commented Aug 1, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 1, 2014

QA tests have started for PR 1464. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17655/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 1, 2014

QA results for PR 1464:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17655/consoleFull

@aarondav
Copy link
Contributor

aarondav commented Aug 1, 2014

Merging into master. Thanks!

@asfgit asfgit closed this in 284771e Aug 1, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@advancedxy @conviva-zz
[Spark 2557] fix LOCAL_N_REGEX in createTaskScheduler and make local-…
568b799 
…n and local-n-failures consistent

[SPARK-2557](https://issues.apache.org/jira/browse/SPARK-2557)

Author: Ye Xianjin <advancedxy@gmail.com>

Closes apache#1464 from advancedxy/SPARK-2557 and squashes the following commits:

d844d67 [Ye Xianjin] add local-*-n-failures, bad-local-n, bad-local-n-failures test case
3bbc668 [Ye Xianjin] fix LOCAL_N_REGEX regular expression and make local_n_failures accept * as all cores on the computer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@advancedxy @AmplabJenkins @pwendell @aarondav @SparkQA