[SPARK-17011][SQL] Support testing exceptions in SQLQueryTestSuite #14592
Conversation
| -- !query 2 schema | ||
| struct<9223372036854775808:decimal(19,0),(-9223372036854775809):decimal(19,0)> | ||
| struct<9223372036854775807:bigint,(-9223372036854775808):decimal(19,0)> |
There was a problem hiding this comment.
"-9223372036854775808" is a valid long value (Long.MinValue) but Spark treats it as a decimal(19, 0) because "9223372036854775808" is out of range. Is this expected?
cc @cloud-fan
There was a problem hiding this comment.
Also cc @sarutak who wrote the original test case.
There was a problem hiding this comment.
maybe a parser bug? cc @hvanhovell
There was a problem hiding this comment.
I'd call this a bug. I tried in Spark 1.6 and it was returning double (which was worse).
Here's postgres:
rxin=# select pg_typeof(-9223372036854775808);
pg_typeof
-----------
bigint
(1 row)
rxin=# select pg_typeof(-9223372036854775807);
pg_typeof
-----------
bigint
(1 row)
rxin=# select pg_typeof(-9223372036854775806);
pg_typeof
-----------
bigint
(1 row)
There was a problem hiding this comment.
@petermaxlee can you file a jira ticket for this bug?
There was a problem hiding this comment.
|
@cloud-fan after adding enough features to the test harness, do you think I should port all tests over in a single pull request, or more incremental? |
|
I'd like to do it incrementally, and ideally one SQL testing file(xxx.sql) one PR, but we can have many PRs at the same time, they are not likely to get conflicted. |
| @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint> | |||
|
|
|||
|
|
|||
| -- !query 2 | |||
| select 9223372036854775808, -9223372036854775809 | |||
| select 9223372036854775807, -9223372036854775808 | |||
There was a problem hiding this comment.
can you also add the boundary conditions for int as well?
There was a problem hiding this comment.
Can I add it in a separate pull request? I want to add all literal parsing here, but don't want to distract this pull request.
|
LGTM pending Jenkins. |
|
Test build #63580 has finished for PR 14592 at commit
|
|
Merging in master. |
|
Test build #63582 has finished for PR 14592 at commit
|
## What changes were proposed in this pull request? This patch adds exception testing to SQLQueryTestSuite. When there is an exception in query execution, the query result contains the the exception class along with the exception message. As part of this, I moved some additional test cases for limit from SQLQuerySuite over to SQLQueryTestSuite. ## How was this patch tested? This is a test harness change. Author: petermaxlee <petermaxlee@gmail.com> Closes #14592 from petermaxlee/SPARK-17011. (cherry picked from commit 0db373a) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
backport to 2.0! |
What changes were proposed in this pull request?
This patch adds exception testing to SQLQueryTestSuite. When there is an exception in query execution, the query result contains the the exception class along with the exception message.
As part of this, I moved some additional test cases for limit from SQLQuerySuite over to SQLQueryTestSuite.
How was this patch tested?
This is a test harness change.