[SPARK-2187] Explain should not run the optimizer twice. #1123
Conversation
|
Nice, this LGTM. This will also make it easy to possibly add the option to view the optimized logical plan though explain at some point as well. |
| // Actually "EXPLAIN" command doesn't cause any side effect. | ||
| override protected[sql] lazy val sideEffectResult: Seq[String] = this.toString.split("\n") | ||
| // Run through the optimizer to generate the physical plan. | ||
| // This is really side effect free but we follow the infrastructure anyway... |
There was a problem hiding this comment.
Is it? Have we fixed all the bugs where generating a plan actually fires off Spark jobs? :P
There was a problem hiding this comment.
I hope so ..... That was an old comment I just rewrote anyway ...
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15886/ |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Ok I am merging this in master & branch-1.0. |
@yhuai @marmbrus @concretevitamin Author: Reynold Xin <rxin@apache.org> Closes #1123 from rxin/explain and squashes the following commits: def83b0 [Reynold Xin] Update unit tests for explain. a9d3ba8 [Reynold Xin] [SPARK-2187] Explain should not run the optimizer twice. (cherry picked from commit 640c294) Signed-off-by: Reynold Xin <rxin@apache.org>
@yhuai @marmbrus @concretevitamin Author: Reynold Xin <rxin@apache.org> Closes apache#1123 from rxin/explain and squashes the following commits: def83b0 [Reynold Xin] Update unit tests for explain. a9d3ba8 [Reynold Xin] [SPARK-2187] Explain should not run the optimizer twice.
@yhuai @marmbrus @concretevitamin Author: Reynold Xin <rxin@apache.org> Closes apache#1123 from rxin/explain and squashes the following commits: def83b0 [Reynold Xin] Update unit tests for explain. a9d3ba8 [Reynold Xin] [SPARK-2187] Explain should not run the optimizer twice.
@yhuai @marmbrus @concretevitamin