Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix #1105

Closed
wants to merge 1 commit into from
Closed

Minor fix #1105

wants to merge 1 commit into from

Conversation

WangTaoTheTonic
Copy link
Contributor

The value "env" is never used in SparkContext.scala.
Add detailed comment for method setDelaySeconds in MetadataCleaner.scala instead of the unsure one.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@@ -91,8 +91,13 @@ private[spark] object MetadataCleaner {
conf.set(MetadataCleanerType.systemProperty(cleanerType), delay.toString)
}

/**
* Set the default delay time( in seconds).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put the space before ( instead of after? Thanks!

@WangTaoTheTonic
Copy link
Contributor Author

Updated.

@pwendell
Copy link
Contributor

Jenkins, test this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15877/

@pwendell
Copy link
Contributor

Thanks, merged into master.

@asfgit asfgit closed this in 67fca18 Jun 19, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
The value "env" is never used in SparkContext.scala.
Add detailed comment for method setDelaySeconds in MetadataCleaner.scala instead of the unsure one.

Author: WangTao <barneystinson@aliyun.com>

Closes apache#1105 from WangTaoTheTonic/master and squashes the following commits:

688358e [WangTao] Minor fix
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
The value "env" is never used in SparkContext.scala.
Add detailed comment for method setDelaySeconds in MetadataCleaner.scala instead of the unsure one.

Author: WangTao <barneystinson@aliyun.com>

Closes apache#1105 from WangTaoTheTonic/master and squashes the following commits:

688358e [WangTao] Minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants