Skip to content

Commit

Permalink
[Minor] Use <sup> tag for help icon in web UI page header
Browse files Browse the repository at this point in the history
This small commit makes the `(?)` web UI help link into a superscript, which should address feedback that the current design makes it look like an error occurred or like information is missing.

Before:

![image](https://cloud.githubusercontent.com/assets/50748/5370611/a3ed0034-7fd9-11e4-870f-05bd9faad5b9.png)

After:

![image](https://cloud.githubusercontent.com/assets/50748/5370602/6c5ca8d6-7fd9-11e4-8d1a-568d71290aa7.png)

Author: Josh Rosen <joshrosen@databricks.com>

Closes #3659 from JoshRosen/webui-help-sup and squashes the following commits:

bd72899 [Josh Rosen] Use <sup> tag for help icon in web UI page header.

(cherry picked from commit f79c1cf)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
  • Loading branch information
JoshRosen committed Dec 10, 2014
1 parent 5e5d8f4 commit ff6f59b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion core/src/main/scala/org/apache/spark/ui/UIUtils.scala
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ private[spark] object UIUtils extends Logging {
</li>
}
val helpButton: Seq[Node] = helpText.map { helpText =>
<a data-toggle="tooltip" data-placement="bottom" title={helpText}>(?)</a>
<sup>
(<a data-toggle="tooltip" data-placement="bottom" title={helpText}>?</a>)
</sup>
}.getOrElse(Seq.empty)

<html>
Expand Down

0 comments on commit ff6f59b

Please sign in to comment.