Optimize code

apache · Jan 21, 2020 · e7b4d43 · e7b4d43
1 parent d18c591
commit e7b4d43
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
@@ -733,7 +733,7 @@ trait CheckAnalysis extends PredicateHelper {
   }
 
   /**
-   * Validates that the root plan is [[Offset]].
+   * Validate that the root node of query or subquery is [[Offset]].
    */
   private def checkOutermostOffset(plan: LogicalPlan): Unit = {
     plan match {

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
@@ -1407,7 +1407,7 @@ object CombineLimits extends Rule[LogicalPlan] {
  *  merging the expressions into one single expression.
  */
 object RewriteOffsets extends Rule[LogicalPlan] {
-  def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
+  def apply(plan: LogicalPlan): LogicalPlan = plan transform {
     case GlobalLimit(le, oe, Offset(noe, grandChild)) =>
       GlobalLimit(le, Greatest(Seq(noe, oe)), grandChild)
     case LocalLimit(le, oe, Offset(noe, grandChild)) =>

diff --git a/...st/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala b/...st/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
@@ -797,7 +797,7 @@ case class Offset(offsetExpr: Expression, child: LogicalPlan) extends OrderPrese
  * So we introduced LocalLimit and GlobalLimit in the logical plan node for limit pushdown.
  */
 object Limit {
-  val INVALID_LIMIT = Literal(Int.MaxValue)
+  val INVALID_LIMIT = Literal(-1)
   def apply(
     limitExpr: Expression,
     offsetExpr: Expression = Literal(0),