Fix review comments.

apache · Sep 23, 2020 · 2bdf800 · 2bdf800
1 parent 90d6329
commit 2bdf800
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/...network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java b/...network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
@@ -267,8 +267,8 @@ public String getID() {
       } catch (IOException ioe) {
         // No exception will be thrown here. req.meta.nioByteBuffer will not throw IOException
         // because it's a NettyManagedBuffer. This try-catch block is to make compiler happy.
-        logger.error("Error in handling failure while invoking RpcHandler#receive() on RPC id "
-            + req.requestId, e);
+        logger.error("Error in handling failure while invoking RpcHandler#receive() on RPC id {}",
+            req.requestId, e);
       } finally {
         req.meta.release();
       }
@@ -296,7 +296,7 @@ private void processOneWayMessage(OneWayMessage req) {
   /**
    * Make a full copy of a nio ByteBuffer.
    */
-  private ByteBuffer cloneBuffer(ByteBuffer buf) {
+  private static ByteBuffer cloneBuffer(ByteBuffer buf) {
     ByteBuffer clone = ByteBuffer.allocate(buf.capacity());
     clone.put(buf.duplicate());
     clone.flip();

diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ErrorHandler.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ErrorHandler.java
@@ -24,7 +24,7 @@
  * and logged.
  * Note: {@link RetryingBlockFetcher} will delegate the exception to this handler only when
  * - remaining retries < max retries
- * - exception is either an IOException or SaslException
+ * - exception is an IOException
  */
 
 public interface ErrorHandler {

diff --git a/.../network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java b/.../network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
@@ -20,7 +20,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.nio.ByteBuffer;
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.Map;

diff --git a/...twork-shuffle/src/test/java/org/apache/spark/network/shuffle/BlockPushExceptionSuite.java b/...twork-shuffle/src/test/java/org/apache/spark/network/shuffle/BlockPushExceptionSuite.java
@@ -22,11 +22,11 @@
 import com.google.common.base.Throwables;
 import org.junit.Test;
 
+import static org.junit.Assert.*;
+
 import org.apache.spark.network.shuffle.protocol.PushBlockStream;
 import org.apache.spark.network.util.JavaUtils;
 
-import static org.junit.Assert.*;
-
 public class BlockPushExceptionSuite {
 
   @Test