-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-49985][SQL] Remove support for interval types in Variant
### What changes were proposed in this pull request? Support for interval types was added to the variant spec. This PR removes this support and removes the ability to cast from interval types to variant and vice versa. ### Why are the changes needed? I implemented interval support for Variant before, but because the Variant spec type is supposed to be open and compatible with other engines which may not support all the ANSI Interval types, more thought needs to be put into the design of these intervals in Variant. ### Does this PR introduce _any_ user-facing change? Yes, after this change, users would no longer be able to cast between variants and intervals. ### How was this patch tested? Unit tests making sure that 1. It is not possible to construct variants containing intervals. 2. It is not possible to cast variants to intervals. 3. Interval IDs in variants are treated just like other unknown type IDs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48215 from harshmotw-db/harshmotw-db/disable_interval_2. Authored-by: Harsh Motwani <harsh.motwani@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
- Loading branch information
1 parent
2bf41a6
commit 2957069
Showing
12 changed files
with
123 additions
and
1,002 deletions.
There are no files selected for viewing
131 changes: 0 additions & 131 deletions
131
common/utils/src/main/scala/org/apache/spark/util/DayTimeIntervalUtils.java
This file was deleted.
Oops, something went wrong.
50 changes: 0 additions & 50 deletions
50
common/utils/src/main/scala/org/apache/spark/util/YearMonthIntervalUtils.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.