Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Bump grpc and protobuff version to allow building on Mac M1 #8186

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

toffentoffen
Copy link
Contributor

Upgrade to the latest grpc-java 1.42.1 which is only compatible and tested against 3.17.2, but we can assume that 3.17.3 (which has osx-aarch_64 compatible maven artifacts) is save to use.

We could have also upgrade to the latest grpc-java 1.42.1 and latest protoc 3.19.1, but it can not be directly done, it needs to tweak the grpcs-java internal dependencies. So we choose the safest option and discarded this option because of the following reasons:

  • Protoc 3.19.1 generates code that relies on methods not available in protobuf-java 3.17.2 (“issue”) (which java-grpc relies on). So we need to tell grpc-java via dependency management to use 3.19.1 instead of 3.17.2.

…c M1

Upgrade to the latest grpc-java 1.42.1 which is only compatible and [tested against](grpc/grpc-java#8551 (comment)) 3.17.2, but we can assume that 3.17.3 (which has osx-aarch_64 compatible maven artifacts) is save to use.

We could have also upgrade to the latest grpc-java 1.42.1 and latest protoc 3.19.1, but it can not be directly done, it needs to tweak the grpcs-java internal dependencies. So we choose the safest option and discarded this option because of the following reasons:
 - Protoc 3.19.1 generates code that relies on methods not available in protobuf-java 3.17.2 ([“issue”](protocolbuffers/protobuf#9236 (comment))) (which java-grpc relies on). So we need to tell grpc-java via dependency management to use 3.19.1 instead of 3.17.2.

Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io>
@toffentoffen toffentoffen force-pushed the issue-8184-bump-grpc-version branch from d8cf55f to 7323a2b Compare November 26, 2021 10:38
@kezhenxu94 kezhenxu94 added this to the 8.9.0 milestone Nov 26, 2021
@kezhenxu94 kezhenxu94 added dependencies Pull requests that update a dependency file backend OAP backend related. labels Nov 26, 2021
@kezhenxu94
Copy link
Member

kezhenxu94 commented Nov 26, 2021

Can you also remove the FAQ regarding the M1 compiling question? I think we don't need them anymore

@wu-sheng
Copy link
Member

We should keep as agent side and old releases still have this issue.

@kezhenxu94
Copy link
Member

kezhenxu94 commented Nov 26, 2021

We should keep as agent side and old releases still have this issue.

People using old releases should read the docs in their corresponding tag and agent should have their own doc and FAQ in their repo. BTW can we also update the gRPC in Java agent?

@wu-sheng
Copy link
Member

Make sense for old release. The current cases is that, docs of old releases are unsearchable.
Agent should be updated too.

@wu-sheng wu-sheng merged commit a621a26 into apache:master Nov 26, 2021
@toffentoffen toffentoffen deleted the issue-8184-bump-grpc-version branch November 29, 2021 08:41
@toffentoffen
Copy link
Contributor Author

toffentoffen commented Nov 29, 2021

@kezhenxu94 should we then delete the FAQ section for MAC M1?
Or should I update it, pointing a comment to the merge commit mentioning that it is not needed for newer releases but still leave the document for older versions?

For gRPC java agent I will create another PR. It has been already done at apache/skywalking-java#74

@kezhenxu94
Copy link
Member

@kezhenxu94 should we then delete the FAQ section for MAC M1?

I suggested to remove but it's @wu-sheng 's call.

@wu-sheng
Copy link
Member

After Java agent is done, I think it is time to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Bump grpc and protobuff version to allow building on Mac M1 osx-aarch_64
3 participants