-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Bump grpc and protobuff version to allow building on Mac M1 #8186
[Enhancement] Bump grpc and protobuff version to allow building on Mac M1 #8186
Conversation
…c M1 Upgrade to the latest grpc-java 1.42.1 which is only compatible and [tested against](grpc/grpc-java#8551 (comment)) 3.17.2, but we can assume that 3.17.3 (which has osx-aarch_64 compatible maven artifacts) is save to use. We could have also upgrade to the latest grpc-java 1.42.1 and latest protoc 3.19.1, but it can not be directly done, it needs to tweak the grpcs-java internal dependencies. So we choose the safest option and discarded this option because of the following reasons: - Protoc 3.19.1 generates code that relies on methods not available in protobuf-java 3.17.2 ([“issue”](protocolbuffers/protobuf#9236 (comment))) (which java-grpc relies on). So we need to tell grpc-java via dependency management to use 3.19.1 instead of 3.17.2. Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io>
d8cf55f
to
7323a2b
Compare
Can you also remove the FAQ regarding the M1 compiling question? I think we don't need them anymore |
We should keep as agent side and old releases still have this issue. |
People using old releases should read the docs in their corresponding tag and agent should have their own doc and FAQ in their repo. BTW can we also update the gRPC in Java agent? |
Make sense for old release. The current cases is that, docs of old releases are unsearchable. |
@kezhenxu94 should we then delete the FAQ section for MAC M1?
|
I suggested to remove but it's @wu-sheng 's call. |
After Java agent is done, I think it is time to remove. |
Upgrade to the latest grpc-java 1.42.1 which is only compatible and tested against 3.17.2, but we can assume that 3.17.3 (which has osx-aarch_64 compatible maven artifacts) is save to use.
We could have also upgrade to the latest grpc-java 1.42.1 and latest protoc 3.19.1, but it can not be directly done, it needs to tweak the grpcs-java internal dependencies. So we choose the safest option and discarded this option because of the following reasons:
CHANGES
log.