Polish documents and introduce webhook health checker #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix bug in the configmap controller * add webhook healthychecker * fix issue in the doc
|
0.5.0 is on the release vote. @hanahmily Is this good enough for 0.6.0? |
hanahmily
requested changes
Dec 9, 2021
yep, we could move this to 0.6.0 |
|
@hanahmily There is a |
pushed by mistake, have deleted it. |
|
@dashanji Could you update |
|
ok, thanks a lot. |
|
updated it. |
hanahmily
reviewed
Dec 10, 2021
| @@ -39,9 +39,6 @@ setup: | |||
| - namespace: skywalking-swck-system | |||
| resource: pod | |||
| for: condition=Ready | |||
| - name: wait webhook installing | |||
| command: | | |||
| bash hack/wait-webhook.sh | |||
There was a problem hiding this comment.
Can we remove wait-webhook.sh? Is it referred to some place else?
|
yep, I have removed it in the last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to do 3 things: