Fix the GHA docker compose wait strategy failure #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the CI. |
added 2 commits
August 19, 2021 23:10
2 tasks
|
@kezhenxu94 Could you take a review on this? |
kezhenxu94
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
It's @mrproliu your call whether to merge this and test first, or wait for upstream PR merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the docker compose wait for IP port failure when using GitHub Action.
I found it's a bug in testcontainers-go.
I have already submit a PR to track this one, before that one merge and release, I provide related code into our project and fix the bug, filename called
compose-provider.go. After this PR have been merge and release, I could remove useless code and usetestcontainers-goproject to verify the docker service health again.